EyeServer
EyeServer copied to clipboard
RubenVerborgh
Refactor to depend on EyeJs?
A while ago, I splitted off the eye wrapper to modernize it and use it in some other project: https://github.com/mielvds/EyeJs Back then, the logical follow-up was to create a PR that would remove this logic and import the EyeJs package (not sure that's the best name either), but I never got to it.
I'm opening this issue to not forget about it and also to check whether this is actually desired.
Happy to make you a package owner. My original idea was that EyeServer would just expose both: https://github.com/eyereasoner/EyeServer/blob/36b3e87fd263af122c8af6ab54ea681eeaab6734/package.js#L1-L2
But I'm not strongly opinionated either way. And also squatted https://www.npmjs.com/org/eyereasoner for us just in case.
Nice move!
Joining packages makes total sense, it was just a necessity at the time. but then this repo would need a total upgrade and transform to typescript?
True; let's leave that as future work 🙂
Or we can already start with having Eye as TypeScript and upgrade the rest later.
My plan was to make the Eye.js api backwards-compatible (reinstate the callbacks and such) so this repo wouldn't need any code changes and leave it at that for the time being