cr-api-ux icon indicating copy to clipboard operation
cr-api-ux copied to clipboard

Popular Decks Include Card Filter

Open IngeniousCoder opened this issue 6 years ago • 3 comments

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'https://royaleapi.com/decks/popular'
  2. Click on 'Include Cards'
  3. Select more then 8 cards
  4. Notice it gets included

Expected behavior Throws error saying that a deck cannot include more then 8 cards

Screenshots image

Desktop (please complete the following information):

  • Windows 7
  • Chrome
  • 22

IngeniousCoder avatar Nov 21 '18 04:11 IngeniousCoder

It does get included. I feel like that you want to use OR search. We don’t support it. Validating for this will be low priority for now.

smlbiobot avatar Nov 21 '18 05:11 smlbiobot

I meant “Popular Decks” page “Include Card” filter had a problem, not “Popular Decks” page to include “card filter”.

IngeniousCoder avatar Nov 21 '18 12:11 IngeniousCoder

@IngeniousCoder I get what you're saying. Essentially, if you pick 10 cards to include in a deck, but the max cards in a deck are 8, you'll get 0 results (as intended). I think the takeaway task on this is:

  • [ ] Create an alert that shows when > 8 cards are in the "include" filter

6Sean avatar Feb 28 '19 21:02 6Sean