design-system icon indicating copy to clipboard operation
design-system copied to clipboard

Remove reliance on retired underlying library by Toast component

Open m7kvqbe1 opened this issue 2 years ago • 2 comments

The underlying library used to implement the Toast component functionality is no longer maintained.

Remove reliance upon this library while maintaining existing public interfaces (if possible).

See comment here.

We've also had issues with React 18 when using Code Sandbox and a quick smoke test in our app. One of the way we got round it was to force the peer dependencies to use React 18. https://docs.npmjs.com/cli/v8/configuring-npm/package-json#overrides

This was cause by an unmaintained lib https://github.com/jossmac/react-toast-notifications. https://github.com/jossmac/react-toast-notifications/blob/2089a9e3511709e5194f1dd77a04d71eadbcb0b1/package.json#L72-L75

Are there any plans to update this toast in the app to not use react-toast-notifications

m7kvqbe1 avatar Apr 20 '22 10:04 m7kvqbe1

This issue has been marked as stale because it has been open for 60 days with no activity

github-actions[bot] avatar Jun 20 '22 01:06 github-actions[bot]

This issue has been marked as stale because it has been open for 60 days with no activity

github-actions[bot] avatar Oct 24 '22 01:10 github-actions[bot]

Closed by https://github.com/Royal-Navy/design-system/commit/e1d5a000ac504fc98fca5fa21189740337ab788b

m7kvqbe1 avatar Feb 16 '24 08:02 m7kvqbe1