ItemRack icon indicating copy to clipboard operation
ItemRack copied to clipboard

Check for valid bag slot before adding tooltip to it

Open DJSchaffner opened this issue 1 year ago • 5 comments

This fixes issues with custom buttons with custom tooltips from other addons.

Example: BetterBags creates a dummy button for displaying empty bag slots.

Before: grafik

After: grafik

DJSchaffner avatar Jun 16 '24 10:06 DJSchaffner

Sorry for the delay. Is this still relevant?

Rottenbeer avatar Sep 26 '24 16:09 Rottenbeer

I am currently not actively playing SoD/Classic and have been using a fork from @romracer with this issue being fixed, so one of his open pull requests might also fix this problem. But in general this problem is probably still relevant.

DJSchaffner avatar Sep 26 '24 19:09 DJSchaffner

@DJSchaffner can you rebase this please?

Rottenbeer avatar Sep 26 '24 20:09 Rottenbeer

Will take a look at it tomorrow evening :)

DJSchaffner avatar Sep 26 '24 21:09 DJSchaffner

My fork has #259 applied which makes this PR not relevant. Since that's been merged here, this can probably be closed.

romracer avatar Sep 27 '24 12:09 romracer