Rot127

Results 554 comments of Rot127

Will be fixed with https://github.com/capstone-engine/capstone/pull/2312

Done. Does this mean you would also like to implement the Capstone module? In this case please let me know. I can/should give you some guidance for this.

@DanielAW As far as I am aware of, you are the only one who did recently public work on Xtensa based firmware. Was there any quality of live improvements you...

Yes, last thing I've seen was the string `ds->opstr` being freed and duplicated up to four times. Somewhere in `asm.c`.

Sure: The pattern is in `ds_build_op_str()`: https://github.com/rizinorg/rizin/blob/c6537d917e2dbb6b5522cb2ecb553d3fa52dee69/librz/core/disasm.c#L923-L924 https://github.com/rizinorg/rizin/blob/c6537d917e2dbb6b5522cb2ecb553d3fa52dee69/librz/core/disasm.c#L987-L988 https://github.com/rizinorg/rizin/blob/c6537d917e2dbb6b5522cb2ecb553d3fa52dee69/librz/core/disasm.c#L1013-L1014 https://github.com/rizinorg/rizin/blob/c6537d917e2dbb6b5522cb2ecb553d3fa52dee69/librz/core/disasm.c#L1064-L1065 The function (maybe the callees as well) needs to be refactored for this I think. I haven't looked in detail,...

@LukeTheEngineer You might want to take a look at https://github.com/rizinorg/rizin/issues/4238. It is loosely connected to this task. But it can give you an idea where to look else.

As a recommendation you can checkout [Valgrinds DHAT](https://valgrind.org/docs/manual/dh-manual.html) tool. It should help al lot to spot the critical allocations.

The analysis and disassembly logic is naturally the one which is most often executed. The task is basically to find the hot execution paths and check where string operations happen....

> ARM detects mode with its PC. If it BX/BLXes or LD/LDMs PC with an odd number, it enters Thumb mode. Are you sure this assumption is correct? Is this...

I think for the first detection method, it is enough if it only works on binaries with given entry points. Otherwise, it gets too complicated (for the beginning). I think...