Rossmaxx
Rossmaxx
> splitting the file up The file is too large, might as well split up the functionality to a base file and helper functions in another file. If it ain't...
A similar CLA exists with microsoft's vcpkg C++ package manager. Might as well be good to have.
But to add, someone in the organisation with the perms should do it.
Mind if i take over?
Since this is a DSK bug, should we leave this open? > The same thing happens in Reaper as well. LMMS is not the only one so def upstream.
Not our bug.
> mingw failures are because the CI running 18.04 has installed libgig-4.0.0, which apparently is right before 4.0.0.svn3 where RIFF::file_offset_t was added (what gig::file_offset_t is typedef'd from). #7259 should fix...
I am thinking of taking over this PR and fixing MSVC builds. For now, the idea I have is to disable version checking on MSVC and force the new behaviour...
Gig player builds on MSVC now, but there seems to be an error while loading files. I'll look into it. @Veratil can you help me with this? It's still fine...
> but there seems to be an error while loading files. nvm. A clean rebuild fixed it.