Tristan Ross

Results 420 comments of Tristan Ross

I've gone ahead and rebased it. I will look into getting tests in shortly.

Can't figure out how the test should be done, I see there's configuration tests but none invoke read.

Ok, I added the test.

I was able to address everything except the `dart analyze` because the two annotations don't like being used together apparently.

Oh, I was looking at the wrong test.

> To finalize this PR, can you please address the following issue Done all those now.

It seems like libxev has some support for wasi32-wasm. After moving `const examples` into the `if (emit_examples)` statement in the `build.zig`, I managed to get these errors: ``` /home/ross/.cache/zig/p/libxev-0.0.0-86vtc4b1EgCl0Kvo2Ixmjfl5PgAaJmvCXRIn_n89nCaR/src/backend/wasi_poll.zig:255:32: error:...

This is definitely a good idea and I can look into it when I have a moment. (I should rename krun to muvm in nixpkgs, didn't know about the rename...