Roshdy Kamel

Results 25 comments of Roshdy Kamel

Where should we chat? My first finding is that this package depends on [React-Resizable](https://github.com/STRML/react-resizable), which has to be modified based on direction to subtract instead of add delata.X on this...

I have sent to you my number in an email. I have committed the changes to your repo. But unfortunately it'll depend on @STRML to accept my [pull request](https://github.com/STRML/react-resizable/pull/96) on...

@sapter I managed to make it work locally. by the time I submitted the PR i had no conflicts, however, i'm ready to solve them if merging is available. But...

I found the problem: in PhoneNumber.js line: 48 ``` isNumeric(n) { return !Number.isNaN(parseFloat(n)) && Number.isFinite(n); } ``` should be: ``` isNumeric(n) { return !Number.isNaN(parseFloat(n)) && !Number.isFinite(n); } ``` **`Number.isFinite` needs...

Workaround: `google.maps.event.trigger(GoogleMaps.maps.map.instance, 'resize');`

@STRML Kindly review and comment