markdown-draft-js icon indicating copy to clipboard operation
markdown-draft-js copied to clipboard

Sample remarkable plugin does not match content beginning with a mention

Open jpribyl opened this issue 3 years ago • 1 comments

https://github.com/Rosey/markdown-draft-js/blob/0a8059cfd03f3678c5dd6c311a50acad16c28756/test/markdown-to-draft.spec.js#L372

0 is falsey in JS, so this will not match a mention at the start of an editor.

A better idea here would be to use something like:

        if (!state.src || typeof state.pos !== 'number') {

A test case could then be added:

  it('can handle editor beginning with block entity data', function () {

Alternatively, it could just be a second check in the existing test:

  it('can handle block entity data', function () {

jpribyl avatar Jun 22 '21 19:06 jpribyl

If desired, I can submit a PR with this change

jpribyl avatar Jun 22 '21 19:06 jpribyl