rosetta icon indicating copy to clipboard operation
rosetta copied to clipboard

fix(DAlphaBall make): Avoid duplicate symbols linker error

Open rebelot opened this issue 1 year ago • 2 comments
trafficstars

Declare-only gmp globals in header file and define them in only one source file

rebelot avatar Apr 10 '24 08:04 rebelot

@rebelot Could you please sign the Rosetta Contributor Licensing Agreement at https://www.rosettacommons.org/forms/cla ? (See https://github.com/RosettaCommons/rosetta/blob/main/CONTRIBUTING.md for more info.)

signed 👌

rebelot avatar Apr 17 '24 10:04 rebelot

@roccomoretti Who are the people with the magic merge powers? I think we should aim to have as little open PRs as possible...

ajasja avatar May 24 '24 06:05 ajasja

They're the @can_merge_to_main team. (And should be able to be pinged as such.)

Agreed that we want to minimize the number of open PRs. This one unfortunately slipped through the cracks. (Sorry @rebelot.)

roccomoretti avatar May 24 '24 14:05 roccomoretti