Roseau_Load_Flow icon indicating copy to clipboard operation
Roseau_Load_Flow copied to clipboard

ENH: `LineParameters` alternative constructors

Open benoit9126 opened this issue 10 months ago • 0 comments

In #121, I realized several things that should be done regarding the LineParameters class. Here is a small list of remaining tasks

  • [ ] In the class method from_geometry, there is a geometric configuration for a twisted line and for an underground line. There is no configuration for overhead line (flag configuration for example). Currently, the overhead is linked to the twisted configuration.
  • [x] In the class method from_geometry, some checks should be done:
    • [x] with an underground line, the height parameter should be negative. For overhead and twisted lines, height should be positive
    • [x] when the sections become large, there is some geometric infeasibility because of the d_{ext}/4 constraint (especially in the twisted configuration) => Maybe modify the provided lengths/dimensions to ensure that no impossible configurations can be generated.
  • [ ] In the class method from_geometry, if no neutral data are provided, maybe consider generating configuration without neutral wire (3x3 matrices). Or take a new "phases" argument to define the number of conductors in the geometric configuration.
  • [ ] The class method from_name_mv uses the Coiffier's coefficients to generate the impedance and shunt admittance matrices. It needs to be refactor in a more interesting name. The documentation doesn't exist...
  • [x] The class method from_name_lv is a wrapper around the from_geometry class method with default values. I think it should be removed.

benoit9126 avatar Aug 25 '23 12:08 benoit9126