ONVIF-Java icon indicating copy to clipboard operation
ONVIF-Java copied to clipboard

- Add port to device hostname; return discovery results as they arrive

Open jpage4500 opened this issue 3 years ago • 3 comments

jpage4500 avatar Jan 26 '21 17:01 jpage4500

Hi @RootSoft - not sure if you're maintaining this project anymore but I found it very useful to help identify ONVIF devices.

There was a couple of changes I wanted/needed though so I made them in a branch:

  1. I'm testing with IP Webcam, an Android app on the Play Store which supports ONVIF discovery. However, it uses port 8080 by default and the devices discovered never contained the port for me
  2. I wanted to show the user results as they came in and not all at the end
  3. I also wanted to know when the discovery was finished (needed to do #2 above)

I'll be doing more testing of this including the other methods but just wanted to see if you were open to the PR while I'm doing more testing

jpage4500 avatar Jan 26 '21 17:01 jpage4500

Oh - I also added a test app (Android).. I just realized not everyone using this library is using it with Android so the test app wouldn't be as helpful to them.. but, hopefully everything else would be

jpage4500 avatar Jan 26 '21 17:01 jpage4500

Hi @jpage4500, unfortunately I have been quite inactive with this project as I have been very busy with private projects. I've noticed this project have seen a lot of traction lately so I will try to be a bit more active here.

Thanks for the PR, I will review it asap!

RootSoft avatar Feb 05 '21 14:02 RootSoft