Ronny Pfannschmidt comments

Results 1745 comments of


                                            Ronny Pfannschmidt

Mention `monkeypatch.undo()` in the docs

Given how monkeypatch works, undo undoes all of them, using the context context manager may be the better detail to recommend

Mention `monkeypatch.undo()` in the docs

Undo is a footgun that may undo patches of other fixtures

Mention `monkeypatch.undo()` in the docs

In fact, since we have contex, I'm in favour of deprecation of undo

Mention `monkeypatch.undo()` in the docs

@nicoddemus i believe that there are next to no valid uses of undo, as it always affects the whole monkeypatch object, which is not safely usable in most cases

Mention `monkeypatch.undo()` in the docs

True, let's move that into a own task

Test listed twice when there's an error during teardown

the ux is confusing that way, can we have one printed report per item so bascially print the call report when teardown passes, not when call passes?

Test listed twice when there's an error during teardown

it should get fixed, we should print the test passed not after the call, but after the teardown to avoid the double print

Misleading error message when parameters are missing in the parametrize but presented in the test function

currently we really cant know (as there wont be a collection node with the name after collection) since parameterization failed @The-Compiler i wonder if we could do a indirect parametrize...

Misleading error message when parameters are missing in the parametrize but presented in the test function

yeah, its a unfortunate edge case, the error itself causes the item not to be "find-able" what could help is taking a look at collection errors in requested paths and...

TypeError: A Message class can only inherit from Message when using pytester and a per-test import google.api_core.exceptions

this is possilby a missing whitelist item in https://github.com/pytest-dev/pytest/blob/611b579d21f7e62b4c8ed54ab70fbfee7c6f5f64/src/_pytest/pytester.py#L753 for now i strongly recommend global import if you need it multiple times anyway