alpha_vantage icon indicating copy to clipboard operation
alpha_vantage copied to clipboard

Added 'month' parameter support for intraday data endpoints

Open masonJamesWheeler opened this issue 1 year ago • 3 comments

Alpha Vantage recently discontinued their intraday_extended and introduced a 'month' parameter to their time-series and indicator data endpoints. This pull request updates the Python wrapper accordingly.

Changes include:

  • Update to support the 'month' parameter for intraday data fetching.
  • Users can now input a month in the format "YYYY-MM" to fetch corresponding intraday data.
  • Necessary adjustments to the relevant functions and methods.

This update should align the wrapper with the latest changes in Alpha Vantage's API and improve the overall user experience.

masonJamesWheeler avatar Jul 14 '23 02:07 masonJamesWheeler

@masonJamesWheeler, hello! Thank you for the PR. I was considering creating my own, but I noticed that you have already created one.

By the way, I took a look at your commit and discovered that it includes a broken file rename, resulting in a broken git history. Could you please revise your commit to fix this issue? I'm concerned that the maintainers might not merge the PR if the history remains broken.

Moreover, TIME_SERIES_INTRADAY_EXTENDED function is depreciated, so TimeSeries.get_intraday_extended() method should be removed or marked as depreciated.

am1ter avatar Jul 16 '23 19:07 am1ter

Thankyou! Working on it now.

From: Aleksei Semenov @.> Date: Sunday, July 16, 2023 at 12:40 PM To: RomelTorres/alpha_vantage @.> Cc: Mason J. Wheeler @.>, Mention @.> Subject: Re: [RomelTorres/alpha_vantage] Added 'month' parameter support for intraday data endpoints (PR #348)

@masonJamesWheelerhttps://urldefense.com/v3/__https:/github.com/masonJamesWheeler__;!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-EW74CgZA$, hello! Thank you for the PR. I was considering creating my own, but I noticed that you have already created one.

By the way, I took a look at your commit and discovered that it includes a broken file rename, resulting in a broken git history. Could you please revise your commit to fix this issue? I'm concerned that the maintainers might not merge the PR if the history remains broken.

Moreover, TIME_SERIES_INTRADAY_EXTENDED function is depreciated, so TimeSeries.get_intraday_extended() method should be removed or marked as depreciated.

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/RomelTorres/alpha_vantage/pull/348*issuecomment-1637173527__;Iw!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-FHAkWqPg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AZPGMIFG3RA26TGUZSXIMMLXQQ7RPANCNFSM6AAAAAA2JW2ICQ__;!!K-Hz7m0Vt54!kwe9uV_KvMA7FkOl6VwhBpnymvCiqIbgOI1EQcO2q_xKRshL8S8S_FAZEL_70SmEXRIwVxkhE42MR-HgNULhOQ$. You are receiving this because you were mentioned.Message ID: @.***>

masonJamesWheeler avatar Jul 17 '23 01:07 masonJamesWheeler

@masonJamesWheeler Thanks for this! I would love to see this merged.

seanbearden avatar Dec 07 '23 21:12 seanbearden

This can be implemented via the 3.0.0 launch in July 2024. Thanks!

AlphaVantageSupport avatar Jul 18 '24 23:07 AlphaVantageSupport