Winget-AutoUpdate icon indicating copy to clipboard operation
Winget-AutoUpdate copied to clipboard

Fix for Group Policy enforced include/exclude lists not being imported corrected

Open nickjisc opened this issue 1 year ago • 3 comments

Proposed Changes

Fix for Group Policy enforced include/exclude lists not being imported corrected.

Previously the GPO allow/block list wasn't getting imported correctly, (empty array), this fixes that by using native powershell registry calls

nickjisc avatar Mar 06 '24 15:03 nickjisc

I went through different path.. Maybe it s worth a look https://github.com/Romanitho/Winget-AutoUpdate/pull/586

Added the uri fetching. It does seem odd you are creating custom objects (key value pair) then ignoring those in the main code base, question if that is needed or you just need an array of the items, which is what I'm doing.

I'm mainly focused on the excluded apps section, as the original code wasn't fully working. New code does seem happy though it can always be slightly optimized

ghost avatar Mar 15 '24 09:03 ghost

II just expanded the function. How it is handled RN in the calling scriptblock was not adjusted at 11PM. I am aware of ongoing discussion about that $appIds.Data thread.

BR AD


From: Nick Brown @.> Sent: 15 March 2024 10:42 To: Romanitho/Winget-AutoUpdate @.> Cc: Andrzej Demski @.>; Comment @.> Subject: Re: [Romanitho/Winget-AutoUpdate] Fix for Group Policy enforced include/exclude lists not being imported corrected (PR #580)

Added the uri fetching. It does seem odd you are creating custom objects (key value pair) then ignoring those in the main code base, question if that is needed or you just need an array of the items, which is what I'm doing.

I'm mainly focused on the excluded apps section, as the original code wasn't fully working. New code does seem happy though it can always be slightly optimized

— Reply to this email directly, view it on GitHubhttps://github.com/Romanitho/Winget-AutoUpdate/pull/580#issuecomment-1999283957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ASAJCPT7I6GYDOT4YEFADN3YYK677AVCNFSM6AAAAABEJJRW26VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJZGI4DGOJVG4. You are receiving this because you commented.Message ID: @.***>