Winget-AutoUpdate icon indicating copy to clipboard operation
Winget-AutoUpdate copied to clipboard

[Bug]: VisualStudio updating even though in excluded list because incorrect ID?

Open ztrhgf opened this issue 1 year ago • 13 comments

The problem

I don't understand how is this possible, but Visual Studio 2022 gets updated even though in excluded list. The reason for this is incorrect ID as can be seen on the following screenshot.

image

What version of WAU has the issue?

1.19.1

What version of Windows are you using (ex. Windows 11 22H2)?

Windows 10 22H2

What version of winget are you using?

v1.6.3482

Log information

No response

Additional information

No response

ztrhgf avatar Jan 17 '24 08:01 ztrhgf

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Feb 18 '24 02:02 github-actions[bot]

ping

ztrhgf avatar Feb 19 '24 08:02 ztrhgf

This seems to be due to the "long" name that is truncated. You've probably blacklisted "Microsoft.VisualStudio.2022.Professional" but WAU sees "Microsoft.VisualStudio.2022.Professio". This is probably a "winget" limitation on the consol output. We need to investigate furthermore, but I think this is the main reason.

Romanitho avatar Feb 19 '24 14:02 Romanitho

With the latest pre-release you can put Microsoft.VisualStudio.2022.* in the list. That should fix it I guess

Romanitho avatar Feb 23 '24 11:02 Romanitho

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Mar 25 '24 02:03 github-actions[bot]

When do you expect to release this version publicly?

ztrhgf avatar Mar 25 '24 13:03 ztrhgf

I think we can now, it is stable enough.

Romanitho avatar Mar 25 '24 13:03 Romanitho

Lovely.

Dne po 25. 3. 2024 14:35 uživatel Romain @.***> napsal:

I think we can now, it is stable enough.

— Reply to this email directly, view it on GitHub https://github.com/Romanitho/Winget-AutoUpdate/issues/548#issuecomment-2018022656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWLN4Z5ZYBM4SLFTSJ6GBLY2AR25AVCNFSM6AAAAABB6DU55GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJYGAZDENRVGY . You are receiving this because you authored the thread.Message ID: @.***>

ztrhgf avatar Mar 25 '24 17:03 ztrhgf

With the latest pre-release you can put Microsoft.VisualStudio.2022.* in the list. That should fix it I guess

Can we use wildcards for example with docker and python also? Didn't notice they was supported.

AusomeOllie10 avatar Mar 26 '24 10:03 AusomeOllie10

Yes you can. Readme is maybe not up to date. Very busy at the moment 😅

Romanitho avatar Apr 02 '24 15:04 Romanitho

I think I now know why IDs may be truncated. We capture the console output, such a virtual window has its own dimensions. e.g. for CMD, the default is 80 characters x 25 lines. When we call WINGET to generate a table, in the case of longer names it tries to stretch the columns to make it look neater. When the first name column is long enough, the ID for products such as VS2022Prof will be shortened because the current, available version and repository columns will always be visible.

It seems that the only way to capture the full, "untruncated" list/table is to redefine the default dimensions of the console that will be used to iterate with (&WINGET)

Something similar to this approach would be required to avoid wildcarded situation

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar May 15 '24 02:05 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar May 29 '24 02:05 github-actions[bot]