User approval feature

[Romanitho]

Proposed Changes

1st version of User Approval feature

Related Issues

(Github link to related issues or pull requests)

[github-actions[bot]]

🦙 MegaLinter status: ⚠️ WARNING

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
⚠️ COPYPASTE	jscpd	yes		17	1.61s
⚠️ MARKDOWN	markdownlint	1	1	4	0.59s
✅ MARKDOWN	markdown-link-check	1		0	5.86s
✅ MARKDOWN	markdown-table-formatter	1	1	0	0.34s
✅ POWERSHELL	powershell	7		0	19.77s
✅ POWERSHELL	powershell_formatter	7		0	11.31s
⚠️ REPOSITORY	checkov	yes		1	11.39s
⚠️ REPOSITORY	devskim	yes		4	0.73s
✅ REPOSITORY	dustilock	yes		no	0.02s
✅ REPOSITORY	gitleaks	yes		no	0.54s
⚠️ REPOSITORY	git_diff	yes		1	0.01s
✅ REPOSITORY	secretlint	yes		no	1.01s
✅ REPOSITORY	syft	yes		no	0.45s
✅ REPOSITORY	trivy	yes		no	3.84s
⚠️ SPELL	cspell	9		251	12.49s
✅ SPELL	misspell	8	2	0	0.07s

See detailed report in MegaLinter reports Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[KnifMelti]

The $WAUConfig.WAU_UserApproval should/must be handled in Get-Policies.ps1 and WAU-admx/adml too

[Romanitho]

True!

[Romanitho]

And I'll probably change the txt file to an XML file with apps info... trying to get things faster a bit.

[Romanitho]

@KnifMelti a quick review to be sure ? not my part, so not sure if I've done it correctly 😅

[KnifMelti]

@KnifMelti a quick review to be sure ? not my part, so not sure if I've done it correctly sweat_smile

When I have the time, yes I noticed you didn't change the version of setting of supported wau version and you must increase the revision of admx/adml

[Romanitho]

Yes. I will.

[Romanitho]

like this ? 😅

[Romanitho]

yes. I wanted to put 1.18.0 🤦🏻‍♂️ But you are my supervisor 👌🏻as always

[ivareri]

I'd like to see this feature implemented, is there anything I can do to help speed it up?

[Romanitho]

Sorry, just back from holidays 😊

You can do anything you want depending on your skills that could help to implement this feature 😇