Winget-AutoUpdate icon indicating copy to clipboard operation
Winget-AutoUpdate copied to clipboard

included_apps.txt bug

Open mtengmo opened this issue 2 years ago • 7 comments

It´s a small bug reinstalling the app with a new included_apps.txt, it doesn´t replace the included_apps.txt if it exists before.

line 206 elseif (!(Test-Path "$WingetUpdatePath\included_apps.txt")) {

Solved with removing the ! elseif ((Test-Path "$WingetUpdatePath\included_apps.txt")) {

mtengmo avatar Sep 02 '22 06:09 mtengmo

@KnifMelti could you check ? I cannot atm 😅 @mtengmo thanks for your help

Romanitho avatar Sep 02 '22 06:09 Romanitho

On it, checking...

KnifMelti avatar Sep 02 '22 12:09 KnifMelti

...can't replicate with https://github.com/Romanitho/Winget-AutoUpdate/releases/tag/v1.14.1 If using: -UseWhiteList A new included_apps.txt from installation source owerwrites the existing one

If using: -UseWhiteList -NoClean A new included_apps.txt from installation source doesn't overwrite the existing one

As it should be...

KnifMelti avatar Sep 02 '22 13:09 KnifMelti

Thanks 😊

Romanitho avatar Sep 02 '22 23:09 Romanitho

@mtengmo If the script has reached line 206 it suggests you have started it with the parameters -UseWhiteList -NoClean (Keep critical files when installing/uninstalling. This setting will keep "excluded_apps.txt", "included_apps.txt", "mods" and "logs" as they were.) Then an "included_apps.txt" will not be overwritten. Could you please check again?

KnifMelti avatar Sep 03 '22 18:09 KnifMelti

Bump.

KnifMelti avatar Sep 09 '22 16:09 KnifMelti

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] avatar Oct 10 '22 03:10 github-actions[bot]

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] avatar Oct 24 '22 04:10 github-actions[bot]