timeshape
timeshape copied to clipboard
RomanIakovlev
Making "Some of the zone ids were not recognized by the Java runtime" messages WARNings instead of ERROR.
Since it not actually an error and is ignored anyways could this message be made a warning instead. Errors are emailed to me in our software and I would prefer not to get email messages everytime it runs.. I could filter out net.iakovlev.timeshape.Index but that would hide any real error messages that could show up.
I think there was at least one request in the past to log this information at ERROR level, so I can't just switch it to WARN, because it will break the existing contract. How about having it configurable when initializing the TimeZoneEngine? I was about rewriting all the overloads of initialize method using the builder pattern anyway, and adding one more parameter into that builder will be no big deal (compared to a yet another overload).
So the default behavior will be to log it at ERROR level still (to avoid breaking the old clients), but there will be an option to log it at a different level. What do you think about such an approach?
All right then. Just FYI, I think it's a good first issue for someone who's interested in making it happen, like yourself. :) I'd be happy to provide guidance if needed, review and release when done.
International geopolitics is less important to our code than all the other stuff that needs to get done so I'll be going back to 2018d.6 for now unless you tell me there's some amazing performance improvements in query lookups since 2018d.6 ;>.
There was actually a performance improvement since 2018d.6, particularly, the support for querying polylines was added since then. It makes it much more fast to run queries on lots of contiguous points. Also the initialization performance should improve due to newer version of Zstandard, although I have no hard numbers to back this up.