amifldrv icon indicating copy to clipboard operation
amifldrv copied to clipboard

doesn't see to work under ubuntu 18.04

Open wjgeorge opened this issue 6 years ago • 3 comments

i was getting error messages:

/tmp/afulnx/amifldrv//amifldrv.c:120:9: error: implicit declaration of function ‘copy_from_user’; did you mean ‘kstrtos8_from_user’? [-Werror=implicit-function-declaration] copy_from_user((void*) &arg_kernel_space, (void*) arg, sizeof(AMIFL_alloc_params)); ^~~~~~~~~~~~ cpu_to_mem

which i traced to a missing #include <linux/uaccess.h>

Adding this allowed the module to compile, but now I get:

46 - Error: Problem getting flash information.

So I hesitate to issue a pull request. Any thoughts?

wjgeorge avatar Aug 11 '18 07:08 wjgeorge

This is likely due to the module source itself having not been upgraded alongside the kernel.

With respect to error 46, it is entirely up in the air as to whether this is due to kernel incompatibilities or SMC/Platform incompatibilities. I know for certain that some newer AMI ISPs do not work with the flashing tool which uses this module.

RomanHargrave avatar Aug 15 '18 04:08 RomanHargrave

wjgeorge can you tell me what packages must be installed on U18 to test this? I too would like to get this working and am having build issues, even on U16.

seitzbg avatar Jan 10 '19 19:01 seitzbg

@seitzbg This is a kernel module, so all that it requires is a kernel. I suspect that any failure to compile is related to kernel changes.

Presently, I have no reason to test or maintain this module. You are welcome to adopt it.

RomanHargrave avatar Jan 14 '19 13:01 RomanHargrave