Romain Marcadier

Results 144 comments of Romain Marcadier

Are you sure the pre-commit hook exits with 0 when invoked from GitX? How did you check that? Ultimately, it could break because your rake script might expect to have...

We're working on a relatively drastic `orchestrion` refactor/reshape, and this would most certainly correctly handle this case (although I need to add a test case specifically for this scenario). We...

We have now released `[email protected]` which ought to address this issue, and has a new mode of operation. I'll close this issue now, but I encourage you to try it...

That sounds like a reasonable feature to have. There's in my opinion some stuff regarding the API there that could use a little tweaking... Like to a certain extent you...

I also just realized that if you add `//dd:span` on a function that is otherwise instrumented (e.g, `net/http` handlers), the tags provided to that directive are appended to the list...

Closing this PR as it was on the pre-0.7 release line. We will look into re-introducing similar functionality in the near future.

We're working on a relatively drastic `orchestrion` refactor/reshape, and this already includes the necessary support for _correctly_ resolving those import paths instead of incorrectly processing both as `v3`. We are...

We have now released `[email protected]` which ought to address this issue, and has a new mode of operation. I'll close this issue now, but I encourage you to try it...

I'm observing this issue with all go releases tested so far (`1.21`, `1.22`, `1.23-rc`), and expect it is present on older releases, too. Investigations so far (superficially) suggest that: -...

Oh my bad, it's fixed in `1.23.0-rc.1` apparently (my tests are failing for another reason). I'm okay with this being closed; however I'd like to understand if there is any...