rocket-learn icon indicating copy to clipboard operation
rocket-learn copied to clipboard

add back deterministic streamer mode

Open Kaiyotech opened this issue 2 years ago • 3 comments

Kaiyotech avatar Aug 23 '22 14:08 Kaiyotech

Is this still a missing feature?

Rolv-Arild avatar Dec 06 '22 23:12 Rolv-Arild

Sort of. Mine is a parameter I can turn on and off, the version in main is always deterministic if streaming I think.

Kaiyotech avatar Dec 06 '22 23:12 Kaiyotech

Actually the check is for streamer_mode > 1, so it is still an option, although definitely a bit obscure. https://github.com/Rolv-Arild/rocket-learn/blob/master/rocket_learn/rollout_generator/redis/redis_rollout_worker.py#L385

Rolv-Arild avatar Dec 12 '22 14:12 Rolv-Arild