optics icon indicating copy to clipboard operation
optics copied to clipboard

[OP#168] Update the font import to use newer syntax

Open Jeremy-Walton opened this issue 6 months ago • 1 comments

Why?

The google font import for Noto Sans and Noto Serif was not including all the available axes for the variable fonts. This change allows for that and actually simplifies the font face file loaded from google and reduces the size of the payload.

What Changed

  • [X] Update import for Noto Sans to use newer syntax. This allows the width axis to be adjusted via the font-stretch css property
  • [X] Add --op-font-family-alt token set to Noto Serif

Sanity Check

  • ~~[ ] Have you updated any usage of changed tokens?~~
  • ~~[ ] Have you updated the docs with any component changes?~~
  • ~~[ ] Have you updated the dependency graph with any component changes?~~
  • [X] Have you run linters?
  • [X] Have you run prettier?
  • [X] Have you tried building the css?
  • [X] Have you tried building storybook?
  • ~~[ ] Do you need to update the package version?~~

Screenshots

Before

Screenshot 2024-07-30 at 6 14 31 PM

After

Screenshot 2024-07-30 at 6 14 53 PM Note: It isn't shown in the image, but the single request is loading both Noto Sans and Noto Serif Screenshot 2024-07-31 at 9 56 38 AM

Jeremy-Walton avatar Jul 30 '24 22:07 Jeremy-Walton