Cryptocurrency-Trading-Bots-Python-Beginner-Advance Fee Percentage Wrong

Fee Percentage Wrong

Open snub-fighter opened this issue 6 years ago • 3 comments

The fee calculation is incorrect it appears.

line 573 ---- fee_percentage = 0.1*3 #divided by 100 pseudo -> fee_percentage = 10%*3 = 30% Shouldn't the fee percentage be 0.001 * 3 not 0.1 * 3 ?

Feb 11 '19 23:02 snub-fighter

Hello - I believe when fee percentage is used, it is either divided by 100 or it compares to a value with a similar order of magnitude.

Feb 12 '19 00:02 Roibal

on line 691, you can see that the calculated fees are multiplied times 100, converting them into percentage. So fee percentage is in percentage,

line 573 ----- fee_percentage = 0.1%*3

Feb 12 '19 00:02 Roibal

Also the fee percentage will be different if you pay with Binance coin as well.

Feb 12 '19 00:02 Roibal