Roger Riggs
Roger Riggs
The check for the tmp directory should be delayed until it is the property is used. If temp files are not used, it only increases startup time without any benefit...
@jaikiran There is advice against exiting with STILL_ACTIVE: [GetExitCodeProcess](https://learn.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getexitcodeprocess) says: > The GetExitCodeProcess function returns a valid error code defined by the application only after the thread terminates. Therefore, an...
Though `waitForInterruptibly(handle)` doesn't check the handle, the code in the caller `ProcessImpl.waitFor()` calls `Thread.interrupted()` and throws the `InterruptedException` if needed. So the exit code is returned only if the process...
The idea from the potential methods above that an extension is a `Path` is non-intuitive and also harder to use. It may have some advantages in the implementation but it...
I would include: 2. `default String getExtension(String default)` returns the extension of the string representation of the path 4. `default boolean hasExtension(String extension, boolean ignoreCase)` returns whether the string representation...
This is still a good idea.
Lets keep this alive and provide and resolve remaining issues.
For a filename to have an extension, then I think there needs to be a non-empty root part. So: ``` ".z", root = ".z" ext = null "z.", root =...
The tests for endianess for DataInputStream are in the TCK and would have caught this case. Tests for endianess are not duplicated in the jtreg test suite.