Tom Lehman

Results 15 issues of Tom Lehman

This gas limit is artificial and users shouldn't have to juggle it themselves. This is similar to automatically increasing the buffer when the user appends "too much" in DynamicBuffer. Many...

BUT, what about: Solady-style implementation of Diamond Storage. You've ADMITTED Diamond Storage is good, you basically use it across all these libraries (and the A contract), and in ERC721 you've...

I would expect this to work: `decode(encode(1234567890123456789012345678901234567890n)) == 1234567890123456789012345678901234567890n` Instead I get `RangeError: 1234567890123456789012345678901234567890 was too large to fit in CBOR 64-bit integer format, set largeBigIntToFloat to convert to float-64`...

Looking at `Util.prefixed? arg` to determine whether to treat something as hex makes it impossible to encode anything that starts with the bytes `[48,120]`, which is not that infrequent. Also,...

Currently `Eth::Tx::Eip1559.decode` has this: `value = Util.deserialize_big_endian_to_int tx[6]` And `deserialize_big_endian_to_int` strips leading `\x00` from the string before converting to an integer ```ruby def deserialize_big_endian_to_int(str) Rlp::Sedes.big_endian_int.deserialize str.sub(/\A(\x00)+/, "") end ``` This...

question