Roger Hardiman

Results 236 comments of Roger Hardiman

For info, my patch on the installed nft (ie in Javascript) is ``` '@serialport/bindings-cpp'({ id, emitAssetDirectory }) { if (id.endsWith('@serialport/bindings-cpp/dist/index.js')) { // SerialPort ships with prebuilt .node files for multiple...

Pull Request #415 submitted to fix this issue

many thanks for merging in the PR. Also thanks for PKG and for NCC, both of which I've used in the past, so glad I could contribute something back.

Good idea to add an integration test. I noticed another one of the binary .node special cases had an integration test.

Just a note to myself that currently one integration test fails with the error below before I add my new integration test ``` ● should correctly trace and correctly execute...

This has been updated with an integrating test. The test code (serialport.js) throws an exception if the .node modules are missing,