Xiu-zhe (Roger) Luo

Results 505 comments of Xiu-zhe (Roger) Luo

> It seems to me that the real value of your package is to be realized when others combine and coordinate these exports to achieve something masterful and otherwise difficult...

I guess this is because we are mangling things by overloading `getproperty` so the instance of ADT does not directly points to the type, which is why it confuses the...

I think https://github.com/Roger-luo/Moshi.jl/ should fix this problem but please feel free to open a new issue under Moshi if it happens.

Ah, thanks, Chris! James warned me about this during JuliaCon2023, actually, lol, but I've written this package with this, so it's a bit hard to change that in this package....

Yeah, that was because the ADT was not implemented in a memory-efficient way back then. I think a few things changed afterwards which was breaking. I learned this from Mason...

which version of Julia are you using? this works for me on 1.9 & 1.8 ```julia julia> @adt D begin D1 D2(::Int) end julia> isbits(D.D1) true ``` we currently forward...

ah thanks! good catch! the `JLKwField` was intended to use for `JLKwStruct` at the beginning, so what actually should be in `JLFunction` is `Expr(:kw, name, default)`, I should have used...

thanks for the PR! actually I just realize we cannot change this convention for functions, this is because the `JLKwField` and `JLField` are used specifically for the structs instead of...

Actually I'd like to learn your use case first, what's your use case of using JLKwField? Part of the reason why I didn't use a type for function kwargs was...