ChromeKeePass icon indicating copy to clipboard operation
ChromeKeePass copied to clipboard

Improve the credential icon

Open Abestanis opened this issue 4 years ago • 0 comments

The current implementation of the credentials icon has a couple of issues:

  • The text inside the input can overlap with the icon.

    The password field on the Amazon login page: The password value overlaps with the credentials icon

  • The same applies for the hint text.

    The username field on the Nextcloud login page: The username hint text overlaps with the credentials icon

  • Other UI elements can also overlay over the icon.

    The username field on Apples login page: A "Next" button is overlaying over the credentials icon

  • We are potentially overwriting a background image of the input that the website specified.

  • We are potentially restoring the wrong title if the website would change it while we hovered over the credentials icon.

To fix these problems, this pull requests uses a separate img element that is positioned above the input field, similar to the dropdown menu.

This fixes the problems described above,

The password field value no longer overlaps with the credentials icon The username field hint text no longer overlaps with the credentials icon other UI elements no longer overlaps with the credentials icon

but it requires us to move the credential icon manually, if the input moved.

This is a test web page in a zip that can be used to test the behavior of the credentials icon on moving inputs.

Abestanis avatar Sep 15 '21 23:09 Abestanis