flutter_branch_sdk icon indicating copy to clipboard operation
flutter_branch_sdk copied to clipboard

Changing the return value in didFinishLaunchingWithOptions crashes the application from SDK version above 8.0.0

Open klim-branch opened this issue 8 months ago • 1 comments

Hi @RodrigoSMarques this is Kun from the Branch integration team!

Describe the bug When the customer make return value change in didFinishLaunchingWithOptions method of the AppDelegate class the app crashes without any logs on flutter-sdk-version >=8.0.0

To Reproduce Change the return value to true didFinishLaunchingWithOptions method

@UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { GeneratedPluginRegistrant.register(with: self) return true } }

image

Screenshots

If you build an app with return true as mentioned above and click on a branch link , it would open the app and crash without any proper logs

Video Behaviour : https://drive.google.com/file/d/1mp3svEGk4ul9VHYHQuFzxtwRgLqthrll/view?usp=sharing

Example Testing Link used: https://musicwiki.app.link/Senhang https://musicwiki.app.link/DRb6YE9a1Jb

Additional Context

  • This issue is happening only from the SDK version above 8.0.0. Previous versions such as 7.1.0 does not appears to have this issue.

  • From the netcore SDK, it is a requirement to return true. Therefore, there is no walkaround for this current solution.

  • I will send out the testing code base via email. Let me know if you are okay with it.

Please let me know if you need anything from my end!

klim-branch avatar Jun 07 '24 02:06 klim-branch