JsTagSphere icon indicating copy to clipboard operation
JsTagSphere copied to clipboard

Does not Support for HTML5

Open developer100rbh opened this issue 6 years ago • 5 comments

Hello, I need to implement this Library in one of my Android Project, but this is too heavy for WebView and does not work on HTML5. I Need HTML5 support with this. Thanks!

developer100rbh avatar Oct 09 '18 13:10 developer100rbh

What would "HTML5" support look like to you?

jkjustjoshing avatar Oct 09 '18 13:10 jkjustjoshing

@jkjustjoshing perhaps it is about words "no HTML5" in index.html page. I'm afraid I've created this little thing some years ago and don't remember what precisely it meant. Probably not that it won't work with HTML5 :)

I'll try to check.

RodionGork avatar Oct 09 '18 13:10 RodionGork

Yeah, to me that means "it works on older browsers", not "it won't work in newer browsers".

jkjustjoshing avatar Oct 09 '18 13:10 jkjustjoshing

@developer100rbh & @jkjustjoshing - thanks for bringing attention to it. I see now that at least in some cases adding <!doctype html> really breaks it. I'll try to take care for it :)

RodionGork avatar Oct 09 '18 14:10 RodionGork

It appeared @tdbts have solved this 4 years ago and proposed PR. I'm very sorry for not merging it in time. For now it is merged (though I think I created some mess with branches off-shooting gh-pages beforehand). But live demo page is now at github pages (see readme) - and it is in HTML5 style.

RodionGork avatar Oct 09 '18 14:10 RodionGork