material-maker
material-maker copied to clipboard
RodZill4
feat: spiral gradient
I'm new to contributing to this project, is there other things I need to add apart from the node?
Hi, and thanks for contributing to this project. :)
There are a couple extra things when adding a node:
- add it to the base library, so it can be easily accessed
- add documentation for the node
- add your contribution to the About dialog and the change to changelog (I'll do those before merging)
Please don't hesitate to ask if you need help.
Hmm maybe it does not need the gradient parameter, and could output a greyscale value (it's easy to use a Colorize node if needed). I'm not sure about the cutoffs either. Being able to select the inner/outer values as well as a bevel (for smooth transition between the spiral and uniform areas) would be nice, but that would make the node a bit too complex. What do you think?
I'll add the docs (I'm assuming they go here?), but I haven't found yet where the base library is configured...
With the gradient input I was doing it for consistency with the other gradient nodes, that all have an input like that, so I think it's reasonable to leave it there.
Hmm, I ported it over from one of my blender projects
I found cutoffs really useful there, but it's debatable for sure. Maybe it's a little too much in this case.
I'd leave it up to you, I'm honestly now tending to remove the cutoff control.
I've done a few changes to get the node more in line with other gradient nodes too
Yes, it looks perfect. Please don't worry if I don't merge it right now. I generally merge new nodes just before release to avoid that users who run dev builds post materials that rely on new stuff (therefore not compatible with current release) on the website. So this will be merged in September.