MobHunting icon indicating copy to clipboard operation
MobHunting copied to clipboard

Grinding detection is broken, sync GrindingManager.saveBlacklist() cause lags

Open ArtNRG opened this issue 4 years ago • 3 comments

The grinding detection is still broken: https://github.com/Rocologo/MobHunting/issues/574

I also noticed that it generates lags on my server even after turning off enable_grinding_detection: false in the config file.

https://spark.lucko.me/#wXKAVS5PM5 one.lindegaard.MobHunting.grinding.GrindingManager.saveBlacklist():54 98.00%

https://github.com/Rocologo/MobHunting/blob/e8d1d1ff21542d4239da11859a4e447b55f9fc33/src/one/lindegaard/MobHunting/grinding/GrindingManager.java#L344

Server Tuinity version git-Tuinity-"e5045a0" (MC: 1.15.2) MobHunting version 7.0.2

ArtNRG avatar Mar 31 '20 07:03 ArtNRG

One more spark report, all recorded ticks are over 1000 ms: https://spark.lucko.me/#2PsudrcoGT one.lindegaard.MobHunting.grinding.GrindingManager.saveBlacklist() 83.35% git-Tuinity-"cc29709" (MC: 1.15.2)

Please do something with it or add the ../Main/pom.xml and dependencies into git so I will be able to fix this.

ArtNRG avatar Apr 10 '20 15:04 ArtNRG

I would love to change pom.xml so I can get some help, but I dont know how to do it. Im not that experienced with maven + jenkins ...

I cant understand why this is a big problem? Do you use /Blacklist all the time? :-)

Rocologo avatar Apr 14 '20 15:04 Rocologo

I don't use /blacklist command, the plugin is perform saving blacklist often after mob killing and do this IO operation in the main thread. You may fix it running saveWhitelist() and saveBlacklist() async. I'm not so experienced too so I advise downloading the plugin from Github in a new folder or even to another computer and try to build it from there, the compiler will show all files you need to add to the git.

ArtNRG avatar Apr 14 '20 20:04 ArtNRG