RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

ENH: Parachute Inflation Modeling

Open ArthurJWH opened this issue 2 months ago • 2 comments

Pull request type

  • [x] Code changes (bugfix, features)

Checklist

  • [ ] Tests for the changes have been added (if needed)
  • [ ] Docs have been reviewed and added / updated
  • [ ] Lint (black rocketpy/ tests/) has passed locally
  • [ ] All tests (pytest tests -m slow --runslow) have passed locally
  • [ ] CHANGELOG.md has been updated (if relevant)

Current behavior

When triggered, the parachute is modeled as fully opened

New behavior

The parachute inflation will be simulated using a volumetric flow model with simple inviscid flow

Breaking change

  • [ ] Yes
  • [ ] No

ArthurJWH avatar Nov 01 '25 01:11 ArthurJWH

@ArthurJWH please rebase your branch to develop so we can properly review this PR. I'm under the impression the 26 commits of this PR should not belong to this git history

Gui-FernandesBR avatar Nov 02 '25 18:11 Gui-FernandesBR

@ArthurJWH tests and linters are not passing.... CHANGELOG needs to be updated,

and, finally, I think there's smth wrong with your git tree again... Could you check the git diff and verify everything is good with your PR?

Let us know whenever you have the PR ready to be reviewed again please.

Gui-FernandesBR avatar Nov 27 '25 12:11 Gui-FernandesBR