RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

ENH: Air brakes controller functions now support 8-parameter signature

Open RahulKrishna145 opened this issue 3 months ago • 2 comments

Pull request type

  • [ ] Code changes (bugfix, features)
  • [ ] Code maintenance (refactoring, formatting, tests)
  • [ ] ReadMe, Docs and GitHub updates
  • [ ] Other (please describe):

Checklist

  • [ ] Tests for the changes have been added (if needed)
  • [ ] Docs have been reviewed and added / updated
  • [ ] Lint (black rocketpy/ tests/) has passed locally
  • [ ] All tests (pytest tests -m slow --runslow) have passed locally

Current behavior

here, air brakes controller doesn't pass environment as parameter but uses the global variables.

New behavior

Now, air brakes controller uses env parameter, you can use the file "test_environment_parameter.py" to check functioning.

Breaking change

  • [ ] No

Additional information

Enter text here...

RahulKrishna145 avatar Sep 29 '25 18:09 RahulKrishna145

@MateusStano could you review this one please?

Gui-FernandesBR avatar Sep 29 '25 19:09 Gui-FernandesBR

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 81.01%. Comparing base (9cf3dd4) to head (bbb2b87). :warning: Report is 21 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #854      +/-   ##
===========================================
+ Coverage    80.27%   81.01%   +0.74%     
===========================================
  Files          104      107       +3     
  Lines        12769    13645     +876     
===========================================
+ Hits         10250    11055     +805     
- Misses        2519     2590      +71     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 27 '25 15:11 codecov[bot]