RocketPy icon indicating copy to clipboard operation
RocketPy copied to clipboard

Google Colab link on "First Simulation" doc page doesn't seem to work

Open jbliesener opened this issue 1 year ago • 3 comments

Describe the bug

"Google Colab" button on "First Documentation" page doesn't work.

To Reproduce

  • Open doc on First Simulation
  • Click on "Google Colab" in the "See also" box
  • Google Colab opens, but can't find the notebook:
Could not find getting_started_colab.html in https://api.github.com/repos/RocketPy-Team/rocketpy/contents/docs/notebooks?per_page=100&ref=master
CustomError: Could not find getting_started_colab.html in https://api.github.com/repos/RocketPy-Team/rocketpy/contents/docs/notebooks?per_page=100&ref=master
    at new FO (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:2450:68)
    at wa.program_ (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:2437:442)
    at za (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:16:57)
    at wa.next_ (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:14:195)
    at kaa.next (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:17:48)
    at b (https://ssl.gstatic.com/colaboratory-static/common/9aff04dde2358fc7be6d8d16cc2c62e5/external_binary_l10n__de.js:17:309)

Expected behavior

Well, I'd expect something like a Jupyter notebook.

Screenshots

Well, it's in German... image

jbliesener avatar Aug 05 '24 20:08 jbliesener

@jbliesener the correct link is https://colab.research.google.com/github/RocketPy-Team/rocketpy/blob/master/docs/notebooks/getting_started_colab.ipynb,

I already fixed it but I'm still waiting for the solution to get to the get to production.

Something is wrong with our documentation building process right now. I will fix it asap.

image

Thanks for opening the issue!

Gui-FernandesBR avatar Aug 05 '24 21:08 Gui-FernandesBR

Thanks for making RocketPy!

jbliesener avatar Aug 05 '24 21:08 jbliesener

Problem solved on the develop branch, waiting for the next release to update the master branch as well.

https://docs.rocketpy.org/en/develop/user/first_simulation.html

Gui-FernandesBR avatar Aug 13 '24 12:08 Gui-FernandesBR