ENH: GNSS
Pull request type
- [x] Code changes (bugfix, features)
Checklist
- [x] Tests for the changes have been added (if needed)
- [x] Docs have been reviewed and added / updated
- [x] Lint (
black rocketpy/ tests/) has passed locally - [x] All tests (
pytest tests -m slow --runslow) have passed locally - [x]
CHANGELOG.mdhas been updated (if relevant)
Changes
- Add class
GNSS - Merges develop and fixes conflicts with new implementations (mainly pylint and FlightPhases refactor)
The noise parameters of the GNSS are much simpler than from the other sensors. I made it so because it seems that errors are taken into account as accuracy rather then noise densities in GNSS sensors.
I am not sure if the way its done is the most robust way of doing this, but it was what I gathered from research
Breaking change
- [ ] Yes
- [x] No
This PR will probably conflict with #632 in the test files
Codecov Report
Attention: Patch coverage is 92.75362% with 5 lines in your changes missing coverage. Please review.
Project coverage is 74.66%. Comparing base (
0b779f2) to head (6265f05). Report is 814 commits behind head on enh/sensors-impl.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| rocketpy/simulation/flight.py | 79.16% | 5 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## enh/sensors-impl #636 +/- ##
====================================================
+ Coverage 73.72% 74.66% +0.93%
====================================================
Files 62 76 +14
Lines 10064 10498 +434
====================================================
+ Hits 7420 7838 +418
- Misses 2644 2660 +16
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.