MNT: Refactors the code to adopt pylint
We are going to officially adopt pylint in this repo.
Github Actions workflows erre updated:
- The black/linter bot will no longer commit to this repo
- When opening a PR, isort, black and pylint will be executed to verify if the code follows
I fixed many pylint errors, but it was a really hard task, quite time consuming. Therefore, I had to use pylint-silent to ignore some errors, those will be solved in the future, one by one.
You don't have to read all the files. Focus on the new github workflow files and the .pylintrc file
We should add a fallback linter: another linter that is run after pylint to capture eventual errors not captured by the main linter.
I would say that ruff, the "yougest and fastest" player in the market right now, is our best candidate. I will let it for the next PR.
Flake8 would be the more "natural" option.
Maybe we could run flake8 AND also ruff.
@phmbressan I have fixed your comments. Please take in mind that I didnt't care too much about the errors threshold at this first time. I was more worried about getting everything to run.
Codecov Report
Attention: Patch coverage is 78.69249% with 88 lines in your changes missing coverage. Please review.
Please upload report for BASE (
develop@23fa110). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## develop #621 +/- ##
==========================================
Coverage ? 73.91%
==========================================
Files ? 70
Lines ? 10032
Branches ? 0
==========================================
Hits ? 7415
Misses ? 2617
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.