helm-charts icon indicating copy to clipboard operation
helm-charts copied to clipboard

Add support for tolerations in all deployments and pods

Open LaloLoop opened this issue 2 years ago • 5 comments

Closes In the Helm chart toleration missed #89

LaloLoop avatar Apr 04 '23 23:04 LaloLoop

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 04 '23 23:04 CLAassistant

@LaloLoop were there any issues with having this merged? This is something we're looking at for an enterprise deployment, we really don't want to have to fork the helm chart!

AlexGidman avatar Apr 29 '24 08:04 AlexGidman

Hi @AlexGidman , we have yet to get any feedback from the RocketChat team. Hello @debdutdeb, @geekgonecrazy . Sorry to tag you directly, I'm adding you as I found your usernames in recent PR reviews/merges. Any chance of getting a review here? Thanks!

LaloLoop avatar Apr 29 '24 20:04 LaloLoop

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

debdutdeb avatar Apr 30 '24 02:04 debdutdeb

Could this key be per-deployment and not common for all?

Maybe there could be a global key that is common, then per-deployment to override each. I see the value in not having to repeat for all deployments.

I'll admit that I don't know all situations where tolerations may be applicable; in our case, the ability to apply tolerations 'globally' is a lot cleaner and sufficient for our purposes.

AlexGidman avatar Apr 30 '24 09:04 AlexGidman