Rocket.Chat
Rocket.Chat copied to clipboard
Don't show leader if unread count is more than 0
[FIX] Leader bar was hiding the unread bar. Don't show it if there are unread messages
I think both should be shown at the same time, don't you?
Not so good on small screens. Once the unread count goes down, the leader will start showing up again.
On Thu, Nov 23, 2017 at 3:04 PM, Diego Sampaio [email protected] wrote:
I think both should be shown at the same time, don't you?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RocketChat/Rocket.Chat/pull/8910#issuecomment-346613195, or mute the thread https://github.com/notifications/unsubscribe-auth/AEWU-5Y-fN3v2PiqQ04pvaQh7BByRbeOks5s5W13gaJpZM4Qlmn5 .
hm... so its this or change stacking order. I'd agree we don't want to keep stacking things down below eats up rel-estate and looks ugly
@sampaiodiego what do you think? Is this ok? I'm guessing if they have unreads they might not be ready to contact lead? UI wise its cleaner, but may cause it to not work as intended?
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Daniel Schreiber seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.