[NEW] Multiple trigger conditions for Livechat

[icosamuel]

@RocketChat/core Addresses part of #1824

New ability to combine different conditions for the triggers already available in the Livechat settings.

New condition type where a trigger works according to the Livechat plugin's language. Here is the new condition attribute once saved to mongodb

"conditions" : [ 
    {
        "id" : 1,
        "name" : "page-url",
        "value" : "http://url.of.your.choice"
    }, 
    {
        "id" : 2,
        "name" : "language",
        "value" : "fr"
    }
    ...
],

[icosamuel]

@sampaiodiego I made an update on my develop branch to make the language condition work with the client language selection that's introduced in PR #8196. Since the translation PR would be required for this feature to be integrated, should I merge both features in the same PR?

What do you suggest?

[JSzaszvari]

This is awesome. Been waiting for this feature for a long time.

[sampaiodiego]

hi @icosamuel I would suggest to still keep them as separate PRs, but I see how difficult it can be.

let me take a closer look into both so I can give you a proper answer

[Vacoi]

hi @sampaiodiego We love livechat, and we would like to suggest a feature: In the email sent with the form (name, email, message) when agents are offline, It would be interesting to include the url of the website from which it was generated. In our company we work with two sites (two hotels) and in this way we know for which hotel information is requested.

[sampaiodiego]

thanks @valentincollado .. that is a good feature.. can you please open a new issue for it? so we all can track it :wink:

[Vacoi]

New issue created #8961

[sampaiodiego]

@icosamuel is there anything missing on this PR? I give it a quick try and seems to be working

[icosamuel]

@sampaiodiego indeed, it currently works with the server's language.

In #8196, I changed that behaviour to be the language of the plugin's host page (with the API call). There is an additional bit of code to make both features work together. This bit of code is only available on my dev branch where I merged both features.

What do you think would be best in this situation?

[edurenye]

I did rebase it, with the latest dev version. livechat-8669-2.txt

[icosamuel]

@edurenye feel free to push in my repo if it helps with the completion of this feature ;)

[edurenye]

Now it passes the tests and eslint

[renatobecker-zz]

Hi @edurenye!

I'll review your PR, sorry for the late reply. Can you please fix the conflicts?

Thanks.

[edurenye]

Sorry, but I'm not working with RocketChat anymore, but if somebody wants to continue with it can ask icosamuel for permission to push to that branch.

[rodrigok]

@renatobecker does this still makes sense?