RocketChat
[NEW] Custom OEmbed providers
@RocketChat/core
Closes #8521
OEmbed admin, based on emoji-custom admin. Add custom OEmbed providers and store on the database. Existing list is preloaded and not editable.
@MartinSchoeler did you want the commit in this pr changed to point to the RocketChat/feature-requests#771 instead of the one close as a dup RocketChat/Rocket.Chat#8521?
I've just found a bug with this where after an upgrade the built in providers are duplicated. @srdjan-catalyst is on it
@sampaiodiego is there anything we can do to help get this across the line?
This pull request introduces 4 alerts and fixes 4 when merging a6abb2cd826b4bbcb2caa129b23bbc752e994e13 into e75482af1eda6c72f8307f3ea940c1b249d8de59 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request introduces 4 alerts and fixes 4 when merging fbe28d8b76f67f19cec7c4c50d55e4dde1d0bb02 into 4ac63d84eabf353f725c1372ad9e2b114a6f196a - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging 7267bbf9cebc10aa0312481fbba0c78aeb74e96c into ac9159da5d53a9717786d7914bc20fbef14f37c3 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging 146612ced046fe78a2b92c7b7829dfa2399c8d4b into 9da49ee0e15f4e9dfaf2a1a979b43d26bb4c7f43 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging 1979367173fe2b8b7222dc3ef4b2bbd9d638e9ea into 7775fe168d44ccf142003e7be5ac0c67bd43b532 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging c7c52f89f7395802f085b60a2690d5e4ab1d8e2b into 56f384083d5933683bd40d67276a370ddf1854d4 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging 9f8e573acdc4f646be9c0502e0f73a82b3814697 into 424f19170c83f93a47333ff6f3d65abbe699e840 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request introduces 4 alerts and fixes 4 when merging c034330ff697672ab1592cea4ac6495c0b550dc7 into 424f19170c83f93a47333ff6f3d65abbe699e840 - view on LGTM.com
new alerts:
- 4 for Incomplete regular expression for hostnames
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 8d67b8e4c17c0bc9016bda48a588bb01283f65c8 into 424f19170c83f93a47333ff6f3d65abbe699e840 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging a3e80f7f35f24e73e0155f85bc2f733ab56eed23 into f77caa306e75529d744a8b9f562316ec00e961f8 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging f247ae7d3b448a64107899f5257bfc4eca96f0d5 into dc949ce03fd16a8001c7bd9ea22614f6a197a5c1 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging d0a012edbb64b81801fd52d9da61558b8cc2d8ab into ee85516ecb2ff0c4997518c274c28095b407b24f - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 7d9975e8f526bace92fdef43a5e584d465db668b into b060e07dc19355fa12a8505d9c7fbea6cf530bef - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging e280da7cf58df7bfff8ea954bd852b5060c2ec58 into dddcb2ab74bf22e91b39ec6182aaef72fefb17b3 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 7b5ca0e5b2337de50d1365918afac7301ff14d81 into dddcb2ab74bf22e91b39ec6182aaef72fefb17b3 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 6b7c084c95d3fa820539ec3729ce5d7b0703770c into e16ef75be10489721b93db9b549185301ff30277 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 7d5a342de9e132959098ae9730c17ff61325e77e into 7d769f66dd333d50e49e6fd4f94b9bdd3de32dad - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
This pull request fixes 4 alerts when merging 2d1d70c506f6e0dcefcfb623768cb6e3aa09181d into a9e95fee3aa289506cb61e2b885e732b8a4dea54 - view on LGTM.com
fixed alerts:
- 4 for Incomplete regular expression for hostnames
@srdjan-catalyst we are going to move those custom things to be registered via the apps engine. Do you want to contribute on that?
Sure, could you please give us some pointers? Unrelated: how do I fix docker push denied: Resource not accessible by integration?
@srdjan-catalyst it's not possible to fix, github doesn't provide secrets on CI when running for a PR from a forked repo for security reasons. We need to remove that step for the forked PRs still.
@d-gubert is our Apps Engine leader. @d-gubert can you talk with @srdjan-catalyst to understand if we have anything missing from the apps engine side to implement those things?