Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Admin option to limit group members

Open billtt opened this issue 8 years ago • 15 comments

@RocketChat/core

Gives the admin an option to limit the number of members in private groups. Sometimes the management of an organization don't want most of the conversations happen in private groups, hence the option.

image

billtt avatar Feb 26 '17 16:02 billtt

@billtt can you please resolve the conflicts?

engelgabriel avatar Mar 01 '17 17:03 engelgabriel

@engelgabriel OK. I thought only the maintainers had the permission to resolve conflicts.

billtt avatar Mar 01 '17 17:03 billtt

@marceloschmidt Actually I did check the limit for group creation, I just forgot to count the creator in lol

billtt avatar Mar 22 '17 01:03 billtt

@marceloschmidt fixed

billtt avatar Mar 22 '17 10:03 billtt

@billtt Can you fix the conflicts?

rodrigok avatar Aug 22 '17 23:08 rodrigok

@billtt Let me know if you can fix the conflicts, mean while I'm moving it to the next release.

rodrigok avatar Dec 08 '17 12:12 rodrigok

@rodrigok Sorry for the delay, haven't got time on this yet. Will fix this as soon as I can.

billtt avatar Dec 10 '17 09:12 billtt

@rodrigok I've fixed the conflicts.

billtt avatar Dec 17 '17 06:12 billtt

@karlprieb how hard would this be to move over to the new ui? The logic behind it is valid and pretty much ready to go, we just need to update it to reflect our new ux/ui.

graywolf336 avatar Apr 18 '18 19:04 graywolf336

I've fixed the conflicts, and it's updated with the new UI now.

billtt avatar Apr 19 '18 06:04 billtt

Thanks @billtt! It has been added to the next release's milestone, so after we release v0.64 we will look into getting it added. :)

graywolf336 avatar Apr 19 '18 14:04 graywolf336

Thanks @graywolf336 I may not check the thread often, so if there is anything wrong (like conflicts), please let me know.

billtt avatar Apr 20 '18 02:04 billtt

Great contribution @billtt 👍 Thank you!

It's working fine, but I have some concerns...

Are we using createCombinedFlex template? Why we still have this template @ggazzo. Maybe we forgot to delete that.

You add the member limit information on create channel page next to Private/Public channel selector like this: screen shot 2018-07-04 at 4 18 14 pm

What if we put this information on the switch label like this screen shot 2018-07-04 at 4 21 44 pm

What you guys think? @RocketChat/core

karlprieb avatar Jul 04 '18 19:07 karlprieb

I think it looks better on the switch label (the second one).

billtt avatar Jul 05 '18 03:07 billtt

Upside to the first one is less to worry about with i18n. But the second one looks a bit better :)

geekgonecrazy avatar Jul 06 '18 19:07 geekgonecrazy