Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: start test conversion from Alsatian to NodeJS

Open d-gubert opened this issue 1 month ago • 13 comments

Proposed changes (including videos or screenshots)

  • [ ] What reporter should we use?

Issue(s)

Steps to test or reproduce

Further comments

d-gubert avatar Nov 24 '25 14:11 d-gubert

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Nov 24 '25 14:11 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: e5f31b2d0156b25692544c0e0df24b127848de4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Nov 24 '25 14:11 changeset-bot[bot]

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch chore/apps-engine-tests-conversion-start

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Nov 24 '25 14:11 coderabbitai[bot]

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 359MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB +1.2KiB
queue-worker-service 132MiB 132MiB -249B
ddp-streamer-service 126MiB 126MiB +998B
account-service 113MiB 113MiB -434B
stream-hub-service 111MiB 111MiB +1.1KiB
authorization-service 111MiB 111MiB -1.2KiB
presence-service 111MiB 111MiB +1.4KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 01:06 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 12 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37592
  • Baseline: develop
  • Timestamp: 2025-12-04 01:06:16 UTC
  • Historical data points: 12

Updated: Thu, 04 Dec 2025 01:06:16 GMT

github-actions[bot] avatar Nov 24 '25 17:11 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 68.79%. Comparing base (355d26d) to head (e76a09d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #37592   +/-   ##
========================================
  Coverage    68.79%   68.79%           
========================================
  Files         3361     3361           
  Lines       114201   114201           
  Branches     20619    20619           
========================================
  Hits         78563    78563           
+ Misses       33543    33538    -5     
- Partials      2095     2100    +5     
Flag Coverage Δ
e2e 57.27% <ø> (+0.01%) :arrow_up:
e2e-api 42.20% <ø> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 24 '25 18:11 codecov[bot]

@copilot following the pattern in this PR, convert the file packages/apps-engine/tests/server/AppManager.spec.ts to a new test using NodeJS built-in test framework.

Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description.

d-gubert avatar Dec 02 '25 11:12 d-gubert

@copilot review this pr

d-gubert avatar Dec 02 '25 11:12 d-gubert

@copilot following the pattern in this PR, convert the file packages/apps-engine/tests/server/managers/AppAccessorManager.spec.ts to a new test using NodeJS built-in test framework.

Avoid modifying any other files. If there are any suggestions you find relevant, document those in the PR description.

d-gubert avatar Dec 02 '25 22:12 d-gubert

@d-gubert I've opened a new pull request, #37678, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Dec 02 '25 22:12 Copilot

@copilot select another test file inside packages/apps-engine/tests/server/*, and convert it to use the NodeJS builtin framework, following the pattern in this PR.

Be sure to select only one test file to convert, and avoid modifying files outside the packages/apps-engine/tests/node-tests directory.

Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file.

d-gubert avatar Dec 03 '25 15:12 d-gubert

@d-gubert I've opened a new pull request, #37683, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Dec 03 '25 15:12 Copilot

@copilot finish the conversion of the test files from Alsatian to NodeJS, following the pattern in this PR.

Avoid modifying files outside the packages/apps-engine/tests/node-tests directory. Create 1 commit per new test file, to make reviewing easier.

Double check test hooks and implementation so that the new test file tests for the same conditions as the source Alsatian test file.

d-gubert avatar Dec 04 '25 10:12 d-gubert

@d-gubert I've opened a new pull request, #37694, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot avatar Dec 04 '25 10:12 Copilot