Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Move enhanced navigation out of feature preview

Open dougfabris opened this issue 2 months ago • 9 comments

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-1351

dougfabris avatar Oct 23 '25 13:10 dougfabris

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Oct 23 '25 13:10 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 245049a8ac9224afaceb98e95ab6153b2b303d1c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 23 '25 13:10 changeset-bot[bot]

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch feat/promote-newNavigation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Oct 23 '25 13:10 coderabbitai[bot]

Codecov Report

:x: Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 72.14%. Comparing base (3c42f0d) to head (0622b2c). :warning: Report is 401 commits behind head on release-8.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-8.0.0   #37285      +/-   ##
=================================================
+ Coverage          66.43%   72.14%   +5.70%     
=================================================
  Files               3276     1454    -1822     
  Lines             109596    75926   -33670     
  Branches           20860    10822   -10038     
=================================================
- Hits               72814    54776   -18038     
+ Misses             34116    20736   -13380     
+ Partials            2666      414    -2252     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 72.14% <90.38%> (+0.57%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 23 '25 15:10 codecov[bot]

Are you seriously going to foist this junk on everyone?

Amongst others..... This is seriously poor and not prime time.

https://github.com/RocketChat/Rocket.Chat/issues/36727

reetp avatar Oct 24 '25 13:10 reetp

Hello @reetp have you considered change your tone? I've been seen you all the time so mad with the community, I don't think this is the spirit of the thing. We're all professionals here mate, we appreciate kind and respect. I already answered you in the issue you attached.

dougfabris avatar Oct 24 '25 15:10 dougfabris

Hello @reetp have you considered change your tone? I've been seen you all the time so mad with the community, I don't think this is the spirit of the thing.

Nope. If it's junk, it's junk.

I've probably done more work in the community here than anyone. Check my record over 9 years. I'm critical if criticism is required.

What I can't stand is an ostrich mentality.

We're all professionals here mate, we appreciate kind and respect.

Respect goes two ways.

Get over it & start listening. That's what professionals do. Accept they've made mistakes. When my staff tell me I've made a mistake I have to listen.

I've raised criticisms & effectively been told "it's great, you'll get used to it & love it". Very Gnome.

I've told you why it's a bad piece of design. And I won't be using it.

https://github.com/RocketChat/Rocket.Chat/issues/33561#issuecomment-3486778007

reetp avatar Nov 06 '25 08:11 reetp

Let me tell you something John, as soon as you raised your concern here, I get into all your comments regarding this feature and detailed it to share with the product team, who makes such decision. I stand there trying to make community being heard, but it seems who doesn't listens is you.

If you've been around for 9 years, you should already know that, although engineers are the ones who raise pull requests, they aren't the ones who make the major product decisions.

I agree with you in a lot of points but in the end, I'm payed to make my work and accept that sometimes is not up to me. The only thing I'm asking you, is to be polite with who dedicate time to listen and talk to you in this open community, because there are others that don't give a shit, so try to be patient as we are with you.

dougfabris avatar Nov 06 '25 13:11 dougfabris

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB +9.2MiB
rocketchat 357MiB 347MiB +9.5MiB
omnichannel-transcript-service 132MiB 132MiB -90KiB
queue-worker-service 132MiB 132MiB -92KiB
ddp-streamer-service 126MiB 126MiB -39KiB
account-service 113MiB 113MiB -37KiB
presence-service 111MiB 111MiB -38KiB
authorization-service 111MiB 111MiB -39KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 17:30", "12/12 20:53 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Statistics (last 19 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37285
  • Baseline: develop
  • Timestamp: 2025-12-12 20:53:00 UTC
  • Historical data points: 19

Updated: Fri, 12 Dec 2025 20:53:01 GMT

github-actions[bot] avatar Dec 05 '25 16:12 github-actions[bot]