fix: adds support for the `sort` parameter in the `getPinnedMessages` API
Proposed changes (including videos or screenshots)
Summary
This pull request adds support for the sort parameter in the getPinnedMessages API, which was previously missing.
Details
After reviewing the current Rocket.Chat source code, the following points were confirmed:
- The
getPinnedMessagesAPI usesfindPaginatedPinnedByRoom, which takesFindOptions<IMessage>as theoptionsparameter. -
FindOptionsincludes asortproperty that can be used to control the result ordering. -
findPaginated(used internally byfindPaginatedPinnedByRoom) also supports sorting via theoptionsparameter.
Conclusion
Therefore, adding support for the sort parameter in the getPinnedMessages API is appropriate and consistent with the current implementation.
Issue(s)
https://github.com/RocketChat/Rocket.Chat/issues/36087
Steps to test or reproduce
Further comments
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the 'stat: QA assured' label
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
🦋 Changeset detected
Latest commit: fafe13435067463514fdaa77780c6462995e3aaa
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 39 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Major |
| @rocket.chat/core-typings | Major |
| @rocket.chat/rest-typings | Major |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/freeswitch | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/http-router | Patch |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-client | Major |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/network-broker | Patch |
| @rocket.chat/mock-providers | Patch |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/ui-voip | Major |
| @rocket.chat/instance-status | Patch |
| @rocket.chat/omni-core | Patch |
| @rocket.chat/omni-core-ee | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR