Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

Search function for file names in groups and direct messages not working

Open hallo43 opened this issue 1 year ago • 8 comments

Description:

I used the file search function in groups and direct messages, but it is not working.
(The search function works fine in channels.)

Additionally, I noticed that each time a character is entered into the search box, the API is called, leading to too many API requests when the keyword consists of multiple characters.
It would be better to allow the user to complete the keyword input and press Enter before triggering the API call.

Steps to reproduce:

Expected behavior:

can search file name

Actual behavior:

Search function for file names in groups and direct messages not working

Server Setup Information:

  • Version of Rocket.Chat Server: 7.2
  • License Type: Starter
  • Number of Users: 5
  • Operating System: Ubuntu 22.0.4
  • Deployment Method: Docker image(pull from github of Rocket.chat)
  • Number of Running Instances: 1
  • DB Replicaset Oplog:
  • NodeJS Version: 20.18.0
  • MongoDB Version: 6.0

hallo43 avatar Jan 10 '25 16:01 hallo43

we can implement debouncing, so that request will go out after 300ms after user stop giving the input or we can add the button component so that request will go out after the button is clicked.

Fahad-Dezloper avatar Jan 11 '25 08:01 Fahad-Dezloper

@reetp assign me this issue

Fahad-Dezloper avatar Jan 11 '25 08:01 Fahad-Dezloper

@reetp assign me this issue

https://gist.github.com/reetp/b0ba4e3d0ea2ff48ca9da00a5a647d42#github

Never @ anyone. I don't work here. I read when I can.

No one assigns issues.

Before starting work, ask on https://open.rocket.chat/channel/support if the team want you to try and fix it as it may already being worked on internally.

Thanks.

reetp avatar Jan 11 '25 09:01 reetp

Seems to exist in 7.2.1 as well

Also the 'Type' box does nothing if you select say images from the dropdown.

reetp avatar Jan 22 '25 16:01 reetp

Seems to exist in 7.2.1 as well

Also the 'Type' box does nothing if you select say images from the dropdown.

i check on v7.2.1 but not work when search in group (thread is OK)

hallo43 avatar Feb 03 '25 10:02 hallo43

Search files doesn't work checked with version 7.7.0

nbao avatar Jun 02 '25 08:06 nbao

Team, will take this to internal teams; might take a while but will be reviewed

casalsgh avatar Jun 03 '25 13:06 casalsgh

@hallo43 i fixed it and created pull request. please wait and flow this PR https://github.com/RocketChat/Rocket.Chat/pull/36162

zscontributor avatar Jun 05 '25 16:06 zscontributor