fix: wrong metric on app stats and error collecting

[d-gubert]

Proposed changes (including videos or screenshots)

• Fix wrong stats for total apps failed metric
• Prevent error being thrown if request to app:getStatus fails

Issue(s)

Steps to test or reproduce

Further comments

[dionisio-bot[bot]]

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 426e293bc7ae806ff8dbe7950576b89ff08bb262

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 40 packages

Name	Type
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/instance-status	Patch
@rocket.chat/ui-theming	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps-engine	Patch
@rocket.chat/ui-composer	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/i18n	Patch
@rocket.chat/meteor	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/apps	Patch
@rocket.chat/models	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
rocketchat-services	Patch
@rocket.chat/api-client	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/network-broker	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions[bot]]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34205/ on branch gh-pages at 2024-12-19 20:30 UTC

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.81%. Comparing base (ed02a33) to head (426e293). Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #34205   +/-   ##
========================================
  Coverage    75.81%   75.81%           
========================================
  Files          512      512           
  Lines        22208    22208           
  Branches      5404     5404           
========================================
  Hits         16837    16837           
  Misses        4720     4720           
  Partials       651      651           

Flag	Coverage Δ
unit	75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[scuciatto]

/patch

[dionisio-bot[bot]]

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:

git fetch
git checkout backport-7.1.1-34205
git cherry-pick 76f6239ff1a9f34f163c03c140c4ceba62563b4e
// solve the conflict
git push

after that just run /patch again

[d-gubert]

/patch

[dionisio-bot[bot]]

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:

git fetch
git checkout backport-7.1.1-34205
git cherry-pick 76f6239ff1a9f34f163c03c140c4ceba62563b4e
// solve the conflict
git push

after that just run /patch again

[d-gubert]

/patch

[dionisio-bot[bot]]

Pull request #34876 added to Project: "Patch 7.1.1"

[d-gubert]

/backport 7.0.4

[dionisio-bot[bot]]

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-7.0.4-34205
git cherry-pick 76f6239ff1a9f34f163c03c140c4ceba62563b4e
// solve the conflict
git push

after that just run /backport 7.0.4 again

[d-gubert]

/backport 7.0.4

[dionisio-bot[bot]]

Pull request #34877 added to Project: "Patch 7.0.4"