chore: use non-root user for alpine images
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the 'stat: QA assured' label
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
⚠️ No Changeset found
Latest commit: 736902d9fea831abbd1d62149f415579d2914dc1
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
PR Preview Action v1.4.8
:---:
:rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34162/
on branch gh-pages at 2025-01-08 08:52 UTC
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 74.99%. Comparing base (
7839bf0) to head (736902d). Report is 24 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #34162 +/- ##
============================================
+ Coverage 59.14% 74.99% +15.85%
============================================
Files 2821 516 -2305
Lines 67981 22746 -45235
Branches 15148 5518 -9630
============================================
- Hits 40208 17059 -23149
+ Misses 24938 5023 -19915
+ Partials 2835 664 -2171
| Flag | Coverage Δ | |
|---|---|---|
| e2e | ? |
|
| e2e-api | ? |
|
| unit | 74.99% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
because you moved the apk del to another layer the image size increased in 200MB, crossing the 2GB mark.. not sure if we want to do something about this though. for reference:
$ docker images
REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/rocketchat/rocket.chat pr-34836.alpine dd8d46039547 19 hours ago 1.81GB
ghcr.io/rocketchat/rocket.chat pr-34162.alpine 248d81b785c5 33 hours ago 2.07GB
ghcr.io/rocketchat/rocket.chat pr-34192.alpine 95935ad7c658 9 days ago 1.82GB
@sampaiodiego while I can reduce the number of layers (ignore the last commit), after checking further seems rocketchat's built code with all deps increased in size. I.e..
debdut@pop-os:~/git/Rocket.Chat$ docker run --rm -ti -u0 --entrypoint du rocketchat-local -sh /app
2.1G /app
debdut@pop-os:~/git/Rocket.Chat$ docker run --rm -ti -u0 --entrypoint du rocketchat/rocket.chat:7.1.0 -sh /app
1.8G /app