fix: twitter oembed image not showing

[abhinavkrin]

Proposed changes (including videos or screenshots)

This pr fixes the issue where the image is not showing link for twitter article links. This pr removes the provider for twitter oembed and hence now relies on the meta tags (which is the default behavior when a provider is not provided).

Issue(s)

Steps to test or reproduce

Further comments

SUP-685

[dionisio-bot[bot]]

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 3acb2c9ffda9920d6fc0b30aa03e6995e9ec4f27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/freeswitch	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/network-broker	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/ui-voip	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[abhinavkrin]

I have not yet added tests, since it would include adding a tweet link for testing. The tests will fail if the tweet is deleted.

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.83%. Comparing base (e2d286c) to head (3acb2c9). Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #34079   +/-   ##
========================================
  Coverage    75.83%   75.83%           
========================================
  Files          511      511           
  Lines        22172    22172           
  Branches      5397     5397           
========================================
  Hits         16814    16814           
  Misses        4710     4710           
  Partials       648      648           

Flag	Coverage Δ
unit	75.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions[bot]]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34079/ on branch gh-pages at 2024-12-17 14:36 UTC